Skip to content

test: increase coverage — between, like, modulo, sort, tail, delete, date ops#597

Open
hermes-fco wants to merge 3 commits into
FCO:masterfrom
hermes-fco:feature/increase-test-coverage
Open

test: increase coverage — between, like, modulo, sort, tail, delete, date ops#597
hermes-fco wants to merge 3 commits into
FCO:masterfrom
hermes-fco:feature/increase-test-coverage

Conversation

@hermes-fco

@hermes-fco hermes-fco commented Jun 11, 2026

Copy link
Copy Markdown

What

Adiciona t/87-coverage-gaps.rakutest com 12 subtests cobrindo funcionalidades do Red que não tinham testes diretos.

Coverage gaps atacados

Feature Status antes Subtests
between (Int e Date) 0 testes 3
like / ilike 0 testes 2
% módulo 0 testes 2
.sort multi-coluna + direção mista mínimo 3
.tail mínimo 2
AND/OR/NOT complexo em grep mínimo 3
.^update batch c/ filtro mínimo 2
.^delete c/ grep e single mínimo 2
.in c/ vazio e single mínimo 2
.^save (update path) implícito 1
Chained methods (sort+head+map) implícito 3
Date two-column range implícito 2

Notas

  • like/`ilikemarcados comskip` em SQLite (não suportado)
  • Testes de sort misto (color asc, price desc) validam ORDER BY multi-coluna com direções diferentes
  • 298 linhas, sem afetar testes existentes

Hermes Agent added 3 commits June 11, 2026 16:07
test: 12 new subtests targeting coverage gaps
b210c12 
Covers previously untested areas:
- between operator (Int and Date)
- like/ilike operators
- modulo (%) operator
- sort with multi-column + mixed direction
- tail on sorted ResultSeq
- date comparisons with two columns
- complex AND/OR/NOT in grep
- batch update with grep
- delete with grep + single delete
- chained methods (sort+head+map, grep+sort+first)
- ResultSeq Bool coercion and .elems
- .in with empty/single-element sets
- .^save update path
fix: .perl → .raku across all lib files (deprecated method)
c3b6208 
- lib/Red/Column.rakumod, Model.rakumod: .perl() → .raku()
- lib/X/Red/Exceptions.rakumod: $.orig-exception.perl → .raku
- lib/Red/Driver/Mock.rakumod: $re.perl() → $re.raku()
- lib/Red/Cli.rakumod: %pars.map(*.perl) → .raku
- lib/Red/Driver.rakumod: @bind.perl()/@binds.perl() → .raku()
tools: coverage runner scripts (Code::Coverage)
a82b79e 
- tools/run-coverage.raku: local runner, runs ALL tests against ALL lib modules
- tools/ci-coverage.raku: CI-friendly, uses prove6 as single runner

Both output percentage to .coverage file.

Note: CI workflow changes must be in base repo (FCO/Red master) —
fork PRs inherit base repo workflows for pull_request events.
@hermes-fco

hermes-fco commented Jun 22, 2026

Copy link
Copy Markdown
Author

Code Review — test: increase coverage — between, like, modulo, sort, tail, delete, date ops

Verdict: Approve (0 critical, 1 warning, 2 suggestions)

Adds 28 subtests across 12 feature categories that had zero/minimal test coverage, plus .perl → .raku deprecation fixes in 6 lib files, and two Code::Coverage runner scripts. +401 / −7 lines, 9 files.

✅ Looks Good

  • t/87-coverage-gaps.rakutest — Well-structured, each subtest has clear assertions with descriptive messages. Restores modified data after UPDATE/SAVE tests (hygiene). LIKE/ILIKE correctly skipped on SQLite.
  • lib/*.rakumod (×6) — .perl → .raku migration is complete and correct across all lib files. No remaining .perl calls in the diff.
  • Model setup — 5 clean test models with appropriate column types, well-documented setup block.
  • Security scan — Clean (no secrets, debug statements, or merge conflicts).

⚠️ Warnings

  • tools/run-coverage.raku:6 — Hardcoded absolute path /root/forks/Red. This script will fail when run from any other directory or machine.

    # Suggestion: derive from script location
my $red-dir = $?FILE.IO.parent(2);  # tools/ → repo root

  • tools/ci-coverage.raku:5 — Hardcoded GitHub Actions path /home/runner/work/Red/Red. Acceptable for CI, but consider documenting or deriving dynamically via %*ENV<GITHUB_WORKSPACE>.

💡 Suggestions

  • PR body states "12 subtests" but the file contains 28 subtest blocks. The 12 refers to feature categories (between, like, modulo, sort, tail, date, AND/OR, update, delete, chained, in, save) — clarifying this avoids confusion.
  • Syntax check could not be run in this sandbox (missing Red dependency). The changes are purely test code and method-rename fixes, so risk is low.

🔍 Minor observations (non-blocking)

  • tools/run-coverage.raku:45 uses pointy block -> (:$key, :$value) — idiomatic Raku, works correctly.
  • Test uses lives-ok for write operations (update/delete/save) — good practice.
  • The NOT between subtest comment says "exclusive-ish" which accurately describes that it's testing the complement, not a strict exclusive range operator.

📊 Stats

Metric Value
Files changed 9
Lines added +401
Lines removed −7
New tests t/87-coverage-gaps.rakutest (28 subtests)
Security scan Clean

Reviewed by Hermes Agent

@hermes-fco hermes-fco mentioned this pull request Jun 22, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hermes-fco